godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.16k stars 97 forks source link

Don't show a progress bar when saving a scene if it takes less than 1 second #4196

Open Calinou opened 2 years ago

Calinou commented 2 years ago

Describe the project you are working on

The Godot editor :slightly_smiling_face:

Describe the problem or limitation you are having in your project

This has two downsides:

The Save Scene action cannot be canceled, so there is no point in displaying a progress bar for such a short action.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Don't show a progress bar when saving a scene if it takes less than 1 second. Only display the EditorProgress dialog if scene saving started more than 1 second ago. This is similar to the recommendation made by Apple's human interface guidelines.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Salvage https://github.com/godotengine/godot/pull/14891 :slightly_smiling_face:

If this enhancement will not be used often, can it be worked around with a few lines of script?

No, as EditorProgress is core editor functionality.

Is there a reason why this should be core and not an add-on in the asset library?

EditorProgress is core editor functionality – it's behavior can't be changed with an add-on.

game009f commented 2 years ago

By default, the progress bar is displayed at the bottom of the interface 1111

Click the progress bar to pop up the task details dialog box 2222