godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.11k stars 69 forks source link

Rename "Selected Collision One Way" to something else #4660

Open ron0studios opened 2 years ago

ron0studios commented 2 years ago

Describe the project you are working on

A 2d game which requires tilemaps with one way collision, i.e a wooden platform

Describe the problem or limitation you are having in your project

I was getting very confused for a while on how to get one-way collision working. Most people were saying the same thing, to look for the option in the menu when selecting a collision-shape. I found out after an hour that this option was indeed available, but it looked as if it was labelled "Selected collision", instead of anything to do with "one way" collision. This was because the rest of the name "selected collision [...] one way" was hidden from view due to screen limitations: image

Describe the feature / enhancement and how it helps to overcome the problem or limitation

I would recommend renaming these properties for people with smaller screens. Something like "One way (selected collision)", or just "one way collision" like for CollisionShape2D (and specify the fact that it is 'selected collision' in the tooltip).

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

I believe this could just be done by making minor changes to some text given that this would require renaming some properties?

If this enhancement will not be used often, can it be worked around with a few lines of script?

Given that this is part of the engine itself, I'm not entirely sure if you can write a workaround.

Is there a reason why this should be core and not an add-on in the asset library?

it would make using the engine much easier for beginners!

Calinou commented 2 years ago

Renaming properties breaks compatibility with existing projects, so this can only be considered for Godot 4.0.

Since the TileMap and TileSet editors were rewritten from scratch for Godot 4.0, can you check whether this property still exists in 4.0.alpha9?

KoBeWi commented 2 years ago

This is how it looks in 4.0: image So the problem still exists as the default width is extremely small. Renaming property is out of question, we could somehow make it display differently though.

Zireael07 commented 2 years ago

Yikes, polygon_0... is very ugly, why is that 0 even there?

KoBeWi commented 2 years ago

Because there can be more polygons.

YuriSizov commented 2 years ago

Both in 3 and 4 it can be made better by grouping. Although in case of 3 it would mean that the properties are collapsed by default. Not sure if it's a big deal for tilemap users or not.

Mickeon commented 2 years ago

Once the properties are expanded they remain open until Godot is closed, so I believe it'd be worth to make their names actually readable by adding a group for them (at least in 3.x, I'm not sure on how the new 4.0 TileMap Editor works)