search

godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.1k stars 69 forks source link

Move text-to-speech methods to a TTS singleton #4681

Open CsloudX opened 2 years ago

CsloudX commented 2 years ago

Describe the project you are working on

NO-GAM Application

Describe the problem or limitation you are having in your project

IMO, move tts methods to TTS class make more sence, like TIME class

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Before After
DisplayServer.tts_speak(String text) TTS.speak(String text)
DisplayServer.tts_stop() TTS.stop()
...

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

/

If this enhancement will not be used often, can it be worked around with a few lines of script?

Where was no problem but make things better.

Is there a reason why this should be core and not an add-on in the asset library?

Yes, it's core.

Calinou commented 2 years ago

cc @bruvzg

ghost commented 2 years ago

cc @bruvzg

Will you please add stt(speech to text) also .

Calinou commented 2 years ago

Will you please add stt(speech to text) also .

Speech to text is much more complex than text to speech, and it doesn't have a standard API exposed by the operating system. Therefore, it's outside the scope of a core feature and should be implemented by an add-on.

ghost commented 2 years ago

Will you please add stt(speech to text) also .

Speech to text is much more complex than text to speech, and it doesn't have a standard API exposed by the operating system. Therefore, it's outside the scope of a core feature and should be implemented by an add-on.

The Android sdk target should be updated we aren't able to target sdk 33. This is why we can't reach more device. Will you implement this please 😇😇

Calinou commented 2 years ago

The Android sdk target should be updated we aren't able to target sdk 33. This is why we can't reach more device. Will you implement this please :innocent::innocent:

See https://github.com/godotengine/godot/issues/48636.

PS: In the future, please don't derail other proposals with unrelated questions. This is your last warning.

KoBeWi commented 2 years ago

IMO making a new singleton for a few methods isn't worth it. But we could maybe move it to OS.