Move font shadow settings to FontVariation for consistency with font outlines

Calinou commented 2 years ago

Describe the project you are working on

The Godot editor :slightly_smiling_face:

Describe the problem or limitation you are having in your project

Font outline widths and colors are already defined on a per-font basis, but the shadow outline and color isn't. This creates an inconsistency in the UI design workflow.
Only a handful of Control-derived nodes support font shadows. Custom drawing doesn't support font shadows unless you do it manually by calling twice with different color and offset.
Label3D doesn't support font shadows either (only outlines).

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Moving font shadow settings to FontVariation allows using font shadows on more nodes than just Label (and perhaps RichTextLabel), such as Button or ItemList.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Add font shadow color and X/Y offset properties to FontVariation.
- Font shadow color defaults to opaque black. Font shadow offset defaults to Vector2(0, 0). When the font shadow offset is Vector2(0, 0), font shadow rendering is disabled regardless of the font shadow color.
Add Font Shadow Offset and Font shadow Color and properties to Label3D.
- Follows the same rules as above.
Deprecate the font shadow theme items in Label, as a custom font variation can be used instead.

If this enhancement will not be used often, can it be worked around with a few lines of script?

No.

Is there a reason why this should be core and not an add-on in the asset library?

This is about fixing an inconsistency in the UI design workflow.

Shadowblitz16 commented 9 months ago

wait what about ui state does this mean we need diffrent fonts for things like pressed, hovered, disabled, focused?

Also... if this gets implimented and this gets implimented... https://github.com/godotengine/godot-proposals/issues/2498

It would be really nice to have font settings for each state

Shadowblitz16 commented 9 months ago

https://github.com/godotengine/godot-proposals/issues/2498

Shadowblitz16 commented 4 months ago

Is this getting added soon? I find it a very big limitation.

Calinou commented 4 months ago

Is this getting added soon? I find it a very big limitation.

This proposal breaks compatibility, so it can't be implemented until Godot 5.0 unless we find a way to do it in a 100% backwards-compatible manner.

Shadowblitz16 commented 4 months ago

Is this getting added soon? I find it a very big limitation.

This proposal breaks compatibility, so it can't be implemented until Godot 5.0 unless we find a way to do it in a 100% backwards-compatible manner.

Why not just add the extra options to font's? I don't see why it breaks compatability

Zireael07 commented 4 months ago

@Shadowblitz16 this proposal is about moving stuff not just adding

godotengine / godot-proposals