search

godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.12k stars 69 forks source link

Make the angular distance of DirectionalLight3D affect its specular lobe #5366

Open atirut-w opened 2 years ago

atirut-w commented 2 years ago

Describe the project you are working on

N/A

Describe the problem or limitation you are having in your project

As of Godot 4.0 beta 16, the angular distance does not seem to affect specular lobes.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

This is not really a problem, but I think it would be a nice addition since omnilights(to self: check other types of lights) size already affect specular lobes.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

N/A

If this enhancement will not be used often, can it be worked around with a few lines of script?

Rendering is core

Is there a reason why this should be core and not an add-on in the asset library?

See above

Calinou commented 2 years ago

Related to https://github.com/godotengine/godot/issues/54244 (possibly due to the same cause).

clayjohn commented 2 years ago

This is already implemented in the clustered renderer: https://github.com/godotengine/godot/blob/d2a6a187f45345f00214c746924c57752a1f5260/servers/rendering/renderer_rd/shaders/scene_forward_clustered.glsl#L1715-L1717 size_A specifies the size to be used for the specular lobe.