godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.17k stars 98 forks source link

Improve PhysicalSkyMaterial #5535

Open KStormStudio opened 2 years ago

KStormStudio commented 2 years ago

Describe the project you are working on

Working on several projects in particular just using Godot 4, a 3D game with a semi-procedural generated world.

Describe the problem or limitation you are having in your project

some small limitations that make PhisycalSky not yet very realistic

Describe the feature / enhancement and how it helps to overcome the problem or limitation

I see the new sky features introduced in Godot 4 and congratulations for your amazing work. If possible I would like to introduce some proposals that should improve the PhisycalSky and make it very close to the UE5 sky atmosphere which works very well too.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

That will be just an improvement of the actual Sky

If this enhancement will not be used often, can it be worked around with a few lines of script?

of course it is not possible to improve it with few lines of script

Is there a reason why this should be core and not an add-on in the asset library?

yes it is part of the Engine

Calinou commented 2 years ago

More parameters to draw the sun directly from SKY editor?

What are you referring to? The sun position is now set by the DirectionalLight3D nodes in the scene. This was done so you don't have to modify the sun position in the environment to suit the light node anymore; it happens automatically.

If you need more control, you can configure each DirectionalLight3D node to only affect the sky rendering – or on the contrary, not affect the sky rendering. PhysicalSkyMaterial only takes the first DirectionalLight3D node into account – it can't draw more than one sun, unlike ProceduralSkyMaterial.