Allow clicking on editor toasts to dismiss them

mieldepoche commented 1 year ago

Describe the project you are working on

stuff

Describe the problem or limitation you are having in your project

to close this notification, I have to reach and click the tiny X button.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Allow dismissing the notification by clicking anywhere in the popup.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Look at how notification popups behave on my machine:

https://github.com/godotengine/godot-proposals/assets/71937306/49b46bb2-72dd-4bb2-b119-8c24bcaf3319

it feels like a button, with a highligh when hovered
for information popups, you don't need to bother aiming on the tiny X button
it has an X button because in some cases, clicking the notification itself can bring the emitter window in front. (but the X button could be kept in godot if it feels better)

If this enhancement will not be used often, can it be worked around with a few lines of script?

it can't

Is there a reason why this should be core and not an add-on in the asset library?

it's a tiny detail that would benefit everyone

TheColorRed commented 1 year ago

I have never seen popup that allowed you to click on the toast to dismiss it. What if you need to copy the information in the toast? You wouldn't be able to as clicking to select would close the toast.

mieldepoche commented 1 year ago

What if you need to copy the information in the toast

afaik the messages are available in the console log, which is better fit for copy pasting imo. Alternatively, a copy button could be added maybe? Next to the X. Also, I'm not even sure you can copy text from them right now. And additionally, I can imagine it may be possible to differentiate between a click (hide the toast) and a click and drag (select text). No clue about how good that would feel.

Calinou commented 1 day ago

I have never seen popup that allowed you to click on the toast to dismiss it.

Windows notifications can be dismissed by clicking on them (if they have no action bound to them).

Also, copying could be implemented with a dedicated button on the toast, which I think is more intuitive.

godotengine / godot-proposals