godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.13k stars 92 forks source link

Move 'Default Clear Color' setting to Editor Settings window instead of Project Settings #8794

Open Bat-Computer opened 9 months ago

Bat-Computer commented 9 months ago

Describe the project you are working on

For the 2D View background and the '3D Advanced Import Settings' background window.

Describe the problem or limitation you are having in your project

It isn't intuitive that to change the background colour of the 2D View and the '3D Advanced Import Settings' window that you have to go into Project Settings>Rendering>Environment>Default Clear Color.

It would seem more logical for it to be in Editor Settings window with the ability then to save the preference the next time you re-open Godot and start a new project.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Personally I find the light grey colour #4d4d4d to be too bright for sprites and tilesets, and it is also too bright for for the '3D Advanced Import Settings' window. But as it is in Project settings it is not saved between different projects as other theme options are.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Move 'Default Clear Colour' settings to the Editor Settings:

Screenshot 2024-01-04 122117

If this enhancement will not be used often, can it be worked around with a few lines of script?

I'm sure it's a quick change ;)

Is there a reason why this should be core and not an add-on in the asset library?

It's just a change of a setting location.

dalexeev commented 9 months ago

This setting is project specific, not editor specific. If you want the editor to remember the setting from the last project, the value must still be copied to Project Settings when creating the project. In my opinion, we can solve this and other similar proposals universally if we add project templates:

Then you can configure one or more templates, which you can select from the drop-down list in the project creation dialog.

Calinou commented 9 months ago

As @dalexeev said, I think it makes more sense that everyone in a team sees the same background color in the Advanced Import Settings dialog. This can significantly impact how you perceive colors after all.

If a temporary override is desired, it should be offered directly within the Advanced Import Settings dialog.