godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.12k stars 69 forks source link

Temperary shadow settings for button just until 5.0? #9745

Closed Shadowblitz16 closed 4 months ago

Shadowblitz16 commented 4 months ago

Describe the project you are working on

Space game

Describe the problem or limitation you are having in your project

I need button shadows really bad but https://github.com/godotengine/godot-proposals/issues/4909 is marked for 5.0

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Can we get a temporary font shadow settings for button until 5.0 rolls around and we get outline and shadows moved to fonts and separate fonts per control state?

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

It would work like label's shadow color and shadow offset x and y in theme and style settings

If this enhancement will not be used often, can it be worked around with a few lines of script?

It would be used in very low resolution pixel art games

Is there a reason why this should be core and not an add-on in the asset library?

Label has it but button's doesn't most controls can be made out of the 5 basic controls of..

but button doesn't have support for shadows and coding separate label's per button state is kinda hard right now.

AThousandShips commented 4 months ago

I need button shadows really bad but #4909 is marked for 5.0

It isn't and never was marked for 5.0? See https://github.com/godotengine/godot-proposals/issues/4909#issuecomment-2088658592, it can't be done unless we find another way, this should be discussed further there instead

Calinou commented 4 months ago

We can implement https://github.com/godotengine/godot-proposals/issues/4909 while keeping the existing shadow properties available (but deprecated). I've edited my proposal accordingly.

Closing in favor of https://github.com/godotengine/godot-proposals/issues/4909.

Shadowblitz16 commented 4 months ago

@Calinou thankyou