godotengine / godot-proposals

Godot Improvement Proposals (GIPs)
MIT License
1.12k stars 69 forks source link

Allow removing projects on disk from the project manager #9814

Open passivestar opened 3 months ago

passivestar commented 3 months ago

Describe the project you are working on

Any project

Describe the problem or limitation you are having in your project

When deleting a project I have to delete it twice - first on disk through the OS file manager, and then in Godot project manager. It would make sense if I could only do it once

I make a lot of small projects for mrps, game prototypes, workflow tests, so having to delete everything twice quickly becomes annoying

Describe the feature / enhancement and how it helps to overcome the problem or limitation

A checkbox in the remove confirmation dialog that allows you to also delete the project folder on disk

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

image

Ideally it would move them to trash instead of removing completely

If this enhancement will not be used often, can it be worked around with a few lines of script?

N/A

Is there a reason why this should be core and not an add-on in the asset library?

N/A

AThousandShips commented 3 months ago

See:

passivestar commented 3 months ago

I read through https://github.com/godotengine/godot/issues/74678, as far as I understood that issue is now pretty much resolved?

The failsafes are:

These seem to be enough, but if deemed necessary it could always be taken a step further (you know how browsers make it super hard for you to visit a plain http sites nowadays, making a "Proceed anyway" a tiny hidden button? could do something like that, but IMO it's a bit excessive at this point)

theraot commented 3 months ago

Type the name of the project to confirm?

passivestar commented 3 months ago

Type the name of the project to confirm?

That's very intrusive, if we do that at least give me a checkbox in the project manager settings to disable it

But typing the project name is usually used for irreversible changes. Deleting a project should be reversible through OS trash bin

AThousandShips commented 3 months ago

But typing the project name is usually used for irreversible changes. Deleting a project should be reversible through OS trash bin

This might not be possible on every OS (it's also possible to disable it) so deleting the project files should be assumed to be destructive

passivestar commented 3 months ago

This might not be possible on every OS (it's also possible to disable it) so deleting the project files should be assumed to be destructive

What if we ask to type the project name only when it's not possible to move to trash? 🤔

AThousandShips commented 3 months ago

That might not be possible to detect

But I don't think the hurdle is significant, if you don't want that protection you can just delete it manually, at your own risk

passivestar commented 3 months ago

Ok then add a hidden ability to copy project's name so that I could easily cheese it 😂

I opened this proposal because it's a bit too many clicks to delete projects, if the new procedure is even harder than to delete manually in OS then it kind of defeats the purpose of this proposal, right?

theraot commented 3 months ago

I derailed, but got a positive response doing it :/

I can see how the friction would not be well recieved. And I think the possitive response is because deleting something by accident is not fun.

However, I do not like having artificially tiny or hard to click UI.

So, what if we just have to type first letter instead of the whole project name? In fact, it can just be a random letter, and the dialog tells you which one.


By the way, copying the project name is probably good on its own right.

And I don't mind if you can disable this on project settings.

Zireael07 commented 3 months ago

If you want single click friction free just delete via your OS/file explorer

Having safeguards here is a good thing

passivestar commented 3 months ago

If you want single click friction free just delete via your OS/file explorer

It isn't single click because it doesn't remove it in the project manager

Alternative proposal: an ability to hide missing projects. This way you can delete a project in OS and it won't clutter the project manager anymore. It will be hidden behind a "Show missing" toggle

Calinou commented 3 months ago

Alternative proposal: an ability to hide missing projects. This way you can delete a project in OS and it won't clutter the project manager anymore. It will be hidden behind a "Show missing" toggle

There is a Remove Missing button that appears if at least one project is missing in the project manager.

I've been wondering if this should be done automatically, but there are valid reasons as for why you'd want missing projects to still show up in the project manager (e.g. because it's on a network drive and you're currently not connected to it).