search

godotjs / javascript

Javascript binding for godotengine
https://godotjs.github.io/
MIT License
963 stars 84 forks source link

Thoughts and comments on moving quickjs to a thirdparty directory? #139

Closed fire closed 11 months ago

fire commented 1 year ago

Thoughts and comments on moving quickjs to a thirdparty directory?

I did in my branch but wanted commentary.

Geequlim commented 1 year ago

Do you mean the thirdparty folder of godot? I don't think it's a good idea. It's simpler to simple clone the repo to godot modules folder and build it for other developers.

Geequlim commented 1 year ago

This module should contains all the dependencies. In V8 or nodejs backend the static libraries will be included instead of build from code with scons.

fire commented 1 year ago

you misunderstood.

  1. javascript/quickjs/quickjs -> javascript/thirdparty/quickjs
fire commented 1 year ago

For example:

  1. javascript/thirdparty/quickjs
  2. javascript/thirdparty/v8
  3. javascript/thirdparty/wasm3
Geequlim commented 1 year ago

That's looks good to me

fire commented 1 year ago

My pr here https://github.com/Geequlim/ECMAScript/pull/156 moves the quickjs folder to thirdparty.

fire commented 11 months ago

Closing after merge. https://github.com/Geequlim/ECMAScript/commit/9a3cd3fe74ebb2dcc26ad496c55a8ae3db9cfe4b