goharbor / harbor

An open source trusted cloud native registry project that stores, signs, and scans content.
https://goharbor.io
Apache License 2.0
23.04k stars 4.65k forks source link

Provide option for use SAML authentication #4982

Open ddudzinski opened 6 years ago

ddudzinski commented 6 years ago

My company looking for integration with SAML for authentication and great if this can be added to the roadmap.

jessehu commented 6 years ago

@ddudzinski is this high priority for your company ?

ddudzinski commented 6 years ago

@jessehu Yes this is high priority for us.

jessehu commented 6 years ago

@ddudzinski Great. Could you please let me know what is your company and how your use case for Harbor? We can connect you with our PM and get this SAML feature planned. My email is huh@vmware.com, in case you need it.

ghost commented 5 years ago

Hi @ddudzinski – thanks for the feedback. This is on our roadmap, but we'd love a PR or two to help with the implementation. 👍

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mkj28 commented 5 years ago

Does commenting on it prevent it from being closed?

mogul commented 5 years ago

I'm also looking for SAML or OIDC integration (and posting to keep the issue from staling out). My use case is to authenticate access to Harbor using Cloud Foundry's UAA as an identity hub.

mogul commented 5 years ago

Never mind, I see that UAA support was explicitly added in 1.4.0. Will open a separate issue about docs.

cafeliker commented 5 years ago

I am looking for the SAML integration feature as well, as our cyber security asks for all the applications need to integrate with PingFederate for authentication purpose.

sykp241095 commented 5 years ago

SAML+1

balonik commented 5 years ago

SAML please

billabongrob commented 5 years ago

Our enterprise would greatly benefit from SAML as well.

Zenithar commented 4 years ago

+1

gozer2222 commented 4 years ago

+1

julioelblanco commented 4 years ago

+1

ZeBidule commented 4 years ago

+1

Zenithar commented 4 years ago

Maybe support external authentication via HTTP headers, in order to delegate SAML/OIDC/Kerberos/etc... authentication via reverse proxy.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mkj28 commented 4 years ago

plz don't close

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

metri commented 4 years ago

don't close

tstrohmeier commented 4 years ago

+1 for SAML or OIDC

futare commented 4 years ago

+1 for SAML

timcappalli commented 4 years ago

I am looking for the SAML integration feature as well, as our cyber security asks for all the applications need to integrate with PingFederate for authentication purpose.

PingFed supports OIDC which is supported in Harbor.

rhyssmith commented 4 years ago

+1 for SAML, or external authentication via HTTP headers so we can do SAML externally.

JasonEverling commented 4 years ago

+1

brtduvally commented 3 years ago

+1 for SAML. We don't want to have to put this behind a jumpbox like we have to do for vSphere.

teamktown commented 3 years ago

+1 for SAML or external headers per comment above by @rhyssmith

sota0113 commented 3 years ago

+1 for SAML.

xaleeks commented 3 years ago

@reasonerjt reviving this, still lots asking for saml

kautkata commented 3 years ago

related thoughts in https://github.com/goharbor/harbor/issues/13276#issuecomment-743769649

Antiarchitect commented 3 years ago

Also SAML

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

metri commented 2 years ago

don't close

timcappalli commented 2 years ago

don't close

Why? There is a very high probability that your IdP supports OIDC. Use newer, more robust protocols instead of going backwards.

brtduvally commented 2 years ago

Why? There is a very high probability that your IdP supports OIDC. Use newer, more robust protocols instead of going backwards.

SAML might be older than OIDC but that doesn't mean it's going away or that everything supporting one will support the other. Unless SAML is expected to be deprecated (it's not) or has a small user base (definitely not) it helps to support both.

timcappalli commented 2 years ago

Why? There is a very high probability that your IdP supports OIDC. Use newer, more robust protocols instead of going backwards.

SAML might be older than OIDC but that doesn't mean it's going away or that everything supporting one will support the other. Unless SAML is expected to be deprecated (it's not) or has a small user base (definitely not) it helps to support both.

It does not make sense to prioritize a legacy protocol when there is significant support for its replacement. So yes, I agree, wouldn't hurt to add SAML, but it shouldn't be prioritized when OIDC is already supported.

teamktown commented 2 years ago

While there's OIDC support, SAML access is still desirable in Harbor but maybe it's not a coding story but an integration story. There are many 1000's of SAML only IdPs who have SAML infra but no OIDC infra online right now.

To me there are two main solution pathways; build it in or eternalize the support. Building it in approach:

Rather than do a ground up implementation there may be some work to leverage or gain inspiration from such as Rancher's go SAML work:

Benefit is the full control of how the implementation WRT how Harbor wants to manage identity internally. As well as friends don't let friends write core security code unless they really have to. Drawback is the effort cost of implementation and ongoing support of internal code, docs, testing etc.

Externalizing SAML Support Approach

Harbor could endorse a pattern of a SAML2OIDC proxy in front of it such as SATOSA and repurpose/dual-purpose the pathway of OIDC

Benefit is a more immediate solution via configuration with fewer dependencies and solution is configuration oriented not code oriented, and less obligation on Harbor as a project Drawbacks are the expanding the moving parts in a different way to external dependencies and possibly requiring advanced knowledge of proxying and maybe some attribute translation business during proxying for important elements.

timcappalli commented 2 years ago

@teamktown I don't think there's a need for Harbor to endorse anything. Identity adapters are a well known entity that are designed to be used without blessing from the application/SP.

Also, if those 1000's of SAML organizations are using Harbor, they should advocate for SAML support. I personally don't think these kind of statistics help the discussion as there is a similar story to be told for any protocol or technology (HTTP vs HTTPs, PEAPv0/EAP-MSCHAPv2 vs EAP-TLS, etc)

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

fooflington commented 2 years ago

While I understand the point about OIDC being available and most SAML IdPs probably supporting OIDC, referring to SAML as a "legacy protocol" doesn't really help the situation - it may not be the newest web-based federated access protocol, but it's very much alive and very much not legacy.

naitmare01 commented 2 years ago

+1 for SAML

limparam commented 2 years ago

+1 for SAML

imurata commented 2 years ago

+1 for SAML. AWS SSO can manage SAML-enabled applications. Because of Harbor's lack of SAML support, my customer who loves Harbor are now going to stop using Harbor after migration to AWS.

github-actions[bot] commented 1 year ago

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

brtduvally commented 1 year ago

This issues is still relevant.

teamktown commented 1 year ago

This issue is still relevant. There's still a wide array of SAML sites that can benefit.

mortenbirkelund commented 1 year ago

+1 for saml

github-actions[bot] commented 1 year ago

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

jiscfoo commented 1 year ago

Would still really like this…!