Open mateusz834 opened 1 year ago
This PR (HEAD: d53187dfe79ebac8b641c125815d580d775e5c95) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: c73cb2584c7c48dae06ac1b69965ae8d2c71d612) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: 4f7f78d26ff311a6e9d78dcb81461d0d3258ccae) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: a431ad14dc8a360b9e304d00683eac0c2392e7fe) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: f6b504c7ce67c2499bd2c3a1437083aa6e0f012f) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: 445464f62eeba16f8f824f15b0a84ae390670b62) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: 4b78ce8f0ff92734c4cddd388d9d94ad4d9dc210) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: 32f3d80a8cc63a29502cf61668bd1b4334b6a537) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Damien Neil:
Patch Set 9: Run-TryBot+1
(11 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 9:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 9:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 9: TryBot-Result-1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 4a0bf943782caf68824be9a20655ecc10cfe522d) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 9:
(6 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Mateusz Poliwczak:
Patch Set 10:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: a62373da45f3a3760427135de8f74919bce40821) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: 3c7399a27955261a1a8a5ae1bc23ac2321ae8a39) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 11:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 106b17329fd49f7e62b9bb4c56ddc32b65eb7e7f) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: 1ab00b076b5392172e0506f6bfe9b561f2fc255b) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: 12a97e07f9652c40c1d0209afe53f1175c2cf2e8) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: 2f47dddc26d222cdcf3c7a794b4e8bf2b58588ed) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: 71b99f1abba145dbc64cbb8b112b455c53616e0c) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: 579098c2a012ea5f878a687ebe2c36c6854c2838) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from tricium-prod@appspot.gserviceaccount.com:
Patch Set 18:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from tricium-prod@appspot.gserviceaccount.com:
Patch Set 19:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Mateusz Poliwczak:
Patch Set 19: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 19:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 19:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 19: TryBot-Result-1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: d09d0d9c0d4d27eb41a5d778abf56a884259dd2c) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 20: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 20:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 20:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 665fb41df16e945ae7b57619bdbef221e0802999) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Gopher Robot:
Patch Set 20: TryBot-Result-1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 95711c73f1fe98a859b9311d7ebe225bd4adbb8e) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 22: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 22:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 22:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 22: TryBot-Result-1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 410fa1617316d7d671a123f47bdfc67e74e4dc98) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 23: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 23:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 23:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 7f5234b5bfde5c2af1694d81670e0af6c2480eb4) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 24: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 24:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 24:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 24: TryBot-Result-1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This change reworks the LookupCNAME handling: 1) It removes the fallback to the go resolver when cgoLookupCNAME faills (even noSuchHosts), this also implies using the canonical name from getaddrinfo. 2) Improves the error handling of the res_search cgo routines, so returning proper &DNSError to match the go resolver behaviour and detecting the noSuchHost condition. 3) Makes the LookupCNAME return the last CNAME in the chain, not the first one.
More details about current issues are described in #59943.
Fixes #59943 Updates #50101