search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
120.74k stars 17.33k forks source link

net: rework the CNAME handling on unix #57093

Open mateusz834 opened 1 year ago

mateusz834 commented 1 year ago

This change reworks the LookupCNAME handling: 1) It removes the fallback to the go resolver when cgoLookupCNAME faills (even noSuchHosts), this also implies using the canonical name from getaddrinfo. 2) Improves the error handling of the res_search cgo routines, so returning proper &DNSError to match the go resolver behaviour and detecting the noSuchHost condition. 3) Makes the LookupCNAME return the last CNAME in the chain, not the first one.

More details about current issues are described in #59943.

Fixes #59943 Updates #50101

gopherbot commented 1 year ago

This PR (HEAD: 3643a9c5d394b80a56053004e687af24df28bba6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 25: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 25:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 25:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 25: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

This PR (HEAD: e9add3960549dcc2290170c67a67eae6b30d9051) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 26: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 26:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 26:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

This PR (HEAD: 06407cd5f4f4ccaf8aac393fdffbf893ed5efe3f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 26: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 27: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 27:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 27:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 27: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 27:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 27:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 27:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 27: -Run-TryBot

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

This PR (HEAD: aafdb96a92a577df3617f8eb095e316ca6933290) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 28: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 28:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 28:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 28: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 28:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 28:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Ian Lance Taylor:

Patch Set 28: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

This PR (HEAD: 460c37a357dc467bf8561808b625747a1838b42d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 29: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 29:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 29:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 29: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

This PR (HEAD: a8f01d7f57321963c49ed42931e4651022eda272) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 1 year ago

This PR (HEAD: 54e797e9d53d85926fbb6415c0eb3b9d426cd2cd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 1 year ago

Message from Ian Lance Taylor:

Patch Set 31: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 31:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 31:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 31: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

This PR (HEAD: 9fccf525b772e2ac14152a3c2ac992615e7df40c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 1 year ago

Message from Ian Lance Taylor:

Patch Set 32: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 32:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 32:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 32: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

This PR (HEAD: 6f04d2df8162080051cefb7e877faed128f33624) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 33: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 33:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 33:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

This PR (HEAD: b411308533d6fe16720def25e3f546baeecf1d53) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 1 year ago

Message from Mateusz Poliwczak:

Patch Set 34: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!

gopherbot commented 1 year ago

Message from Gopher Robot:

Patch Set 34:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!