Open mateusz834 opened 1 year ago
Message from Gopher Robot:
Patch Set 34:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 48b3f9e1112cb9912d518962bbbcba712bb930dc) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Gopher Robot:
Patch Set 34: TryBot-Result-1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Mateusz Poliwczak:
Patch Set 35: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 35:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 35:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 35: TryBot-Result-1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 9b90c8b903b1c5531a0739e86c4fe880c1b06a07) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 36: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 36:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 36: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Mateusz Poliwczak:
Patch Set 36:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Mateusz Poliwczak:
Patch Set 36: -Run-TryBot
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: fb70d73683c8978280a4c8399b773763ed4b75f1) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 37: Run-TryBot+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 37:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 37:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: ce861197c0497946820958433cde922270dd9810) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: d470332c996d576abe4741f5b537c3cfdd9b79de) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 39: Run-TryBot+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 39:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 39:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 429a4ac0f5e45021b9d656967ed5629349b7dedd) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 40: Run-TryBot+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 40:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 40:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: c6439b01e5faeb3ec63b7904246ebd59a33eca72) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 41: Run-TryBot+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 41:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 42:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Mateusz Poliwczak:
Patch Set 42: Run-TryBot+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 42:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 1f1fdaedae8956464f71dfcf1b1c4710fdbc47ea) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: 4ebf2f59ed846bc18273736533d51c3d77ccdcd7) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 44: Run-TryBot+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 44:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 44:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 8b196c8fe6d373fd98aafef52338f4a9bc8fdbfb) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 45: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 45:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 45:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 72a06407f0bc2a0061abe6cd206bc6554fd33bcd) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 46: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 46:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 46:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 67a4f12cdaeae42eaaa4339b278c22082df2e171) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Mateusz Poliwczak:
Patch Set 47: Run-TryBot+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 47:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 47:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/455275. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: cd671a3e3e9d359f92c034f9569c7d7462d99174) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/455275 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This change reworks the LookupCNAME handling: 1) It removes the fallback to the go resolver when cgoLookupCNAME faills (even noSuchHosts), this also implies using the canonical name from getaddrinfo. 2) Improves the error handling of the res_search cgo routines, so returning proper &DNSError to match the go resolver behaviour and detecting the noSuchHost condition. 3) Makes the LookupCNAME return the last CNAME in the chain, not the first one.
More details about current issues are described in #59943.
Fixes #59943 Updates #50101