gonetz / GLideN64

A new generation, open-source graphics plugin for N64 emulators.
Other
775 stars 180 forks source link

Feature: new GUI #1213

Closed gonetz closed 7 years ago

gonetz commented 8 years ago

Aquatakat designed new nice GUI layout. Code is in https://github.com/gonetz/GLideN64/tree/feature_new_gui feature branch.

WIP build: https://drive.google.com/file/d/0B0YqMPjGo3B2TGpsenpZeTVsWUU/view?usp=sharing

We need your feedback.

Aquatakat commented 7 years ago

I'm using Creator 4.10 on Qt 5.7. I'll try extracting one of the bmp sizes into its own file and using that instead.

I think it's probably likely that whatever Qt that gonetz is using to compile doesn't support PNG at all. I remember when I originally designed the form and all the various icons in it I was using plain jane .png files which worked on my preview but not when compiled.

Aquatakat commented 7 years ago

Alright, @gonetz #1281

oddMLan commented 7 years ago

Now that you mention it, I think the version he uses is actually stripped of any PNG support, It's a situation in which the inbuilt libpng library in QT conflicts with Hi-res texture support, so he uses his own static libpng build lib into the project.

@gonetz The current stable version of QT is 5.7.0 and has MSVC 2015 support. Do you think it's time to upgrade the solution? It's a bummer that QT takes so long to install and setup though.

Maybe the new version doesn't have the problem with the PNG support.

Aquatakat commented 7 years ago

I'm wondering if we could just archive the 128x128 and 256x256 icons for now - there's not currently anywhere they're displayed.

gonetz commented 7 years ago

we could just archive the 128x128 and 256x256 icons for now

Yes, we could.

gonetz commented 7 years ago

The feature merged to master. I squashed all dev commits into 1 commit. Ryan, Thanks!

Aquatakat commented 7 years ago

You're welcome.

oddMLan commented 7 years ago

Is the question mark (?) useful for anything? imagen It should be removed from the titlebar.

Aquatakat commented 7 years ago

@oddMLan I tried to figure out a way to remove that question mark in the XML but I wasn't successful. Maybe I'll poke around in the C++.

Aquatakat commented 7 years ago

@gonetz It looks like a quick and easy change based on this to remove the "What's This" question mark from the title bar by changing the two spots where QDialog() is called to include Qt::WindowTitleHint | Qt::WindowSystemMenuHint as the second argument. I would create a pull request, but C++ is too foreign to me―I don't even know if Qt is an accessible object there.

gonetz commented 7 years ago

Yes, it works. Thanks!

oddMLan commented 7 years ago

I see two issues now

gonetz commented 7 years ago

@Aquatakat

Can the problem with Gamma override combobox be fixed without cpp modification?

Aquatakat commented 7 years ago

@gonetz Unfortunately not, but the fix is simple. #1299

gonetz commented 7 years ago

Thanks!