google-deepmind / pysc2

StarCraft II Learning Environment
Apache License 2.0
7.96k stars 1.15k forks source link

Update colors.py to support Python 3.9 and later #350

Open craigdods opened 1 year ago

craigdods commented 1 year ago

The random.shuffle function in Python's standard library doesn't take a second argument in Python versions 3.9 and onwards.

Previously, random.shuffle allowed for a random generator function as its second argument, but this feature was deprecated in Python 3.9 and has been removed in Python 3.10 and onwards.

Without the patch, we're presented with a Traceback:

  File "../lib/python3.11/site-packages/pysc2/lib/colors.py", line 224, in categorical
    palette = shuffled_hue(palette_size)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "../lib/python3.11/site-packages/pysc2/lib/colors.py", line 121, in shuffled_hue
    random.shuffle(palette, lambda: 0.5)  # Return a fixed shuffle
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

TypeError: Random.shuffle() takes 2 positional arguments but 3 were given
google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Kaszanas commented 2 months ago

I confirm that this is a working solution. I had the same problem, had to internally change this to have a working environment.