google / upvote_py2

A multi-platform binary whitelisting solution
Apache License 2.0
452 stars 35 forks source link

Add support for filtering hosts by primary user #20

Closed thehesiod closed 5 years ago

thehesiod commented 5 years ago

Here's how I did it: https://github.com/farmersbusinessnetwork/upvote/commit/4c87e9b59d67215f7430463f68b1984f4ff13cf9

thehesiod commented 5 years ago

btw, looks like the name of the search box doesn't change if you click search by ID or now by primary user. Perhaps instead the title should be query, or removed.

screen shot 2018-10-11 at 3 26 37 pm

thehesiod commented 5 years ago

btw, another thing missing for all of these search pages is wildcard support

chief8192 commented 5 years ago

That whole search widget is definitely less that ideal, and is something that we hope to replace if we overhaul the admin UI.

thehesiod commented 5 years ago

ok going to add another feature request: sorting by column :)

thehesiod commented 5 years ago

closing this in favor of https://github.com/google/upvote/issues/24