search

google / upvote_py2

A multi-platform binary whitelisting solution
Apache License 2.0
452 stars 35 forks source link

UI: searching by host ID broken #40

Open thehesiod opened 5 years ago

thehesiod commented 5 years ago

from in the search() method it assumes all searches by id will load a card, however on the host page there is no card. Further, you're not allowed to use a searchBase of id so it's broken in a couple ways

thehesiod commented 5 years ago

I just fixed this, added to my big fixes issue: https://github.com/google/upvote/issues/24

thehesiod commented 5 years ago

ugh, with my fix searching by https://[PROJ].appspot.com/admin/hosts/[HOSTID] is still broken, I think race condition between loadData and loadCard

thehesiod commented 5 years ago

fixed in https://github.com/farmersbusinessnetwork/upvote/commit/d9122a14c657d6ab668c3abb03f6afc095b430ec

thehesiod commented 5 years ago

another issue, this is similarly broken on the events page as well, you get "Invalid searchBase blockable_id"