search

google / upvote_py2

A multi-platform binary whitelisting solution
Apache License 2.0
452 stars 35 forks source link

logupload endpoint missing #41

Closed thehesiod closed 5 years ago

thehesiod commented 5 years ago

when we set a host to upload logs, we're getting 404 on GET [PROJ].appspot.com/api/santa/logupload/[HOSTID]

thehesiod commented 5 years ago

I think this used to work?

thehesiod commented 5 years ago

https://github.com/google/upvote/commit/627be9243fd09f3a79f2eb7ac717b33f4d6e205f#diff-f2a0e440ce8d9365518d8f9e869da2f1 Gets rid of the obsolete santa_api LogUploadHandler and BinaryUploadHandler huh? it's still exposed through the hosts UI and supported by santa

chief8192 commented 5 years ago

Ahhh, that's actually being used? Neither we or the Santa team have touched it for some time. And the binary upload feature was never finished in the client. I'll get the log upload added back.

russellhancox commented 5 years ago

The log upload stage in Santa has been somewhat broken for some time and no-one had noticed, so we removed it from the client (in the upcoming release) rather than fix it. If this is a feature you really want, please open an issue on the Santa project so we can consider re-adding (and fixing) it.

chief8192 commented 5 years ago

Thanks for clarifying, Russell. I thought that was only the case for binary upload.

thehesiod commented 5 years ago

well, it's still available via the upvote UI: https://github.com/google/upvote/blob/master/upvote/gae/modules/upvote_app/frontend/admin_ui/hostpage/hosts.html#L158

chief8192 commented 5 years ago

Yeah, that bit should have been deleted as well

thehesiod commented 5 years ago

k, will leave this open for that part to get removed then

thehesiod commented 5 years ago

don't forget https://github.com/google/upvote/blob/master/upvote/gae/modules/santa_api/sync.py#L304 and I think there are implications in the DB as well