search

googlefonts / gfregression

Test local fonts against fonts host on fonts.google.com
Apache License 2.0
14 stars 10 forks source link

Less destructive deployment #24

Closed m4rc1e closed 6 years ago

m4rc1e commented 6 years ago

This app runs on a tiny Digital Ocean droplet. Because of this constraint the DB and app are inside the same container. This is bad because if we rebuild the container, we lose all the data.

Since We have a few open prs in fonts/google which must remain intact. I cannot rebuild the containers just yet. Once the prs have been merged. I'll work on giving the db its own container. This means we can rebuild the webapp without destroying any existing comparisons.

cc @davelab6 @madig

m4rc1e commented 6 years ago

Using docker for deployment was simple (pre database days). During the flight to Berlin, I'll see if using http://flask.pocoo.org/docs/0.12/patterns/fabric/ is easier for individuals to spin their own instance. My original intention for this app was KISS. I avoided using front end frameworks so perhaps dropping Docker should alsomake things easier.

madig commented 6 years ago

Maybe an easy way to start it locally with the option to put it in a container? Would also help with development.

Kind of like how you can clone Impallari's font testing repo and immediately start using it by starting php.

madig commented 6 years ago

Why a database, anyway?

m4rc1e commented 6 years ago

Why a database, anyway?

When I make pull requests. Reviewers can inspect the changes themselves. Here's one for FrancoisOne https://github.com/google/fonts/pull/1475

davelab6 commented 6 years ago

We need to throw away your DO container anyway and move it to GCP.

davelab6 commented 6 years ago

This repo need to move to /googlefonts org ASAP :)