search

googlefonts / gfregression

Test local fonts against fonts host on fonts.google.com
Apache License 2.0
14 stars 10 forks source link

contenteditable and fixed install link #3

Closed alexeiva closed 7 years ago

m4rc1e commented 7 years ago

@alexeiva sorry for the delay in looking at this.

A couple of things: -Squash the Update README.md prs -Currently, the right column is content editable. The left column is not screen shot 2016-11-28 at 13 07 45

Otherwise, I'm cool with this. Good job.

m4rc1e commented 7 years ago

Bang! thank you!

alexeiva commented 7 years ago

bing! Next up I am working on this:

screen shot 2016-11-28 at 2 35 53 pm

Your script only fetches the Latin range from the GF servers. I cannot compare the new and old Cyrillic. Sad story. Is this an easy fix?

m4rc1e commented 7 years ago

This test was just for the vertical metrics.

I'd prefer to do this sort of testing in a new page called languages.

m4rc1e commented 7 years ago

You have to intelligently find the language as well. nothing here is arbitrary like Impallari/testing.

alexeiva commented 7 years ago

I can't properly set v metrics without regards to other scripts.

For just checking if the v metrics diverge from sources Latin will suffice.

So, languages tab is a good idea

On Nov 28, 2016 2:39 PM, "Marc Foley" notifications@github.com wrote:

This test was just for the vertical metrics.

I'd prefer to do this sort of testing in a new page called languages.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/m4rc1e/gfregression/pull/3#issuecomment-263273359, or mute the thread https://github.com/notifications/unsubscribe-auth/AP3Q6c83Z2l6Ucue1x_qiRIaLn0h3yxGks5rCtmegaJpZM4Kz6Pe .

m4rc1e commented 7 years ago

Yes you can.

Your vertical metrics should not be based on Vietnamese or any scripts. We use the Latin script to establish the appearance of our vertical metrics. If people need Vietnamese or other tall scripts without collisions, they'll have to adjust the leading/line-height.

Read the mega thread on our Google discussion Khaled's proposed vertical metrics setup. We've favoured Khaled's approach on old fonts and Kalapi's for new fonts.