search

googleforgames / quilkin

Quilkin is a non-transparent UDP proxy specifically designed for use with large scale multiplayer dedicated game server deployments, to ensure security, access control, telemetry data, metrics and more.
Apache License 2.0
1.3k stars 95 forks source link

improvement: add note about measure units of jitter metric #1014

Closed zifter closed 1 month ago

zifter commented 2 months ago

What type of PR is this? /kind documentation

What this PR does / Why we need it: This PR improves documentation

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

XAMPPRocky commented 2 months ago

Thank you for your PR, and congrats on your first contribution! 🎉

XAMPPRocky commented 2 months ago

@markmandel I think something went wrong with cloud build.

XAMPPRocky commented 2 months ago

@zifter Oh you, also need to sign the CLA for this be merged.

zifter commented 2 months ago

@XAMPPRocky i've done it a long time ago there is an issue with bot, not with my CLA https://github.com/googleforgames/quilkin/commit/4ef2ec28bb73b2d2f50b6b1cf5c7da3eac223728 Author: @quilkin-bot 84364394+quilkin-bot​@users.noreply.github.com

markmandel commented 2 months ago

Weird, the quilkin bot is failing CLA. It shouldn't be a thing that it even worries about. I'll override it if need be.

markmandel commented 2 months ago

/gcbrun

(this is needed for people who don't have read access to the repo so the Cloud Build script runs - I forgot this as well)

markmandel commented 2 months ago

Ah, found the issue with the bot, that should be fixed now. Weird flake in the unit tests:

---- ipv6_firewall_allow stdout ----
thread 'ipv6_firewall_allow' panicked at src/components/proxy.rs:94:91:
called `Result::unwrap()` on an `Err` value: Os { code: 98, kind: AddrInUse, message: "Address already in use" }
stack backtrace:
   0: rust_begin_unwind
             at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/std/src/panicking.rs:647:5
   1: core::panicking::panic_fmt
             at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/panicking.rs:72:14
   2: core::result::unwrap_failed
             at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/result.rs:1649:5
   3: core::result::Result<T,E>::unwrap
             at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/result.rs:1073:23

Will retry.

zifter commented 1 month ago

any updates? :)

markmandel commented 1 month ago

whoops! Thanks for the ping.

markmandel commented 1 month ago

/gcbrun

quilkin-bot commented 1 month ago

Build Succeeded :partying_face:

Build Id: 2c007a4d-1aeb-4ff9-afa5-9d7fc0a4cecb

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/1014/head:pr_1014 && git checkout pr_1014
cargo build