search

googleforgames / quilkin

Quilkin is a non-transparent UDP proxy specifically designed for use with large scale multiplayer dedicated game server deployments, to ensure security, access control, telemetry data, metrics and more.
Apache License 2.0
1.29k stars 94 forks source link

Don't vendor protoc on Windows #814

Open XAMPPRocky opened 1 year ago

XAMPPRocky commented 1 year ago

protobuf-src depends on auto tools which requires sh, so this means if you're trying to compile on Windows, it will fail.

error: failed to run custom build command for `protobuf-src v1.1.0+21.5`

Caused by:
  process didn't exit successfully: `C:\Users\erin.power\quilkin\target\release\build\protobuf-src-668a2e07a68a77fb\build-script-build` (exit code: 101)
  --- stderr
  thread 'main' panicked at '
  `sh` is required to run `configure`

  build script failed, must exit now', C:\Users\erin.power\.cargo\registry\src\index.crates.io-6f17d22bba15001f\autotools-0.2.6\src\lib.rs:781:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
markmandel commented 1 year ago

https://github.com/MaterializeInc/rust-protobuf-native/issues/4 is relevant, with links off to how some other projects solved the issue.

benesch commented 5 months ago

The latest version of protobuf-src now builds with CMake rather than autotools. I've not yet tested this, but it may "just work" with Windows now.