googlemaps / android-maps-utils

Maps SDK for Android Utility Library
https://developers.google.com/maps/documentation/android-sdk/utility
Apache License 2.0
3.54k stars 1.53k forks source link

feat: added StreetViewUtil #1200

Closed kikoso closed 1 year ago

kikoso commented 1 year ago

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #1201 🦕

sonatype-lift[bot] commented 1 year ago

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

kikoso commented 1 year ago

The implementation LGTM! Please add usage documentation to the README to explain this utility's purpose and how to use it.

This has been added.

kikoso commented 1 year ago

Please also add unit tests. Thank you!

I have added three different unit tests. We could add Dagger to provide DI and a more granular testing level, but probably this suffices and we keep the library lean.

googlemaps-bot commented 1 year ago

:tada: This PR is included in version 3.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: