search

gorilla-devs / GDLauncher-Carbon

GDLauncher Carbon is a simple, yet powerful Minecraft custom launcher with a strong focus on the user experience
https://gdlauncher.com
Other
110 stars 12 forks source link

Mod image caching and endpoints #206

Closed iluminn closed 1 year ago

linear[bot] commented 1 year ago
GDL-356 Backend mod images

Required for [GDL-323](https://linear.app/gd-linear/issue/GDL-323/mods-images-are-not-showing-in-the-mods-list)

iluminn commented 1 year ago

Less mods than expected have an icon defined in the file but it works. In the future it might help to pick a platform fallback icon based on where the pack is from. (can't approve my own pr)

blarfoon commented 1 year ago

This clearly does not do what it's supposed to. Very few mods have a built-in icon hence it can't be used as a reliable source. Should rather use images from the corresponding modplatform. Reverting until fixed