Open jquesada2016 opened 10 months ago
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to cla-requests@gdlauncher.com and add your github handle to contributors list.
Currently, the project does not have a `rustfmt.toml`, causing inconsistant formatting for users who contribute with a non-default global `rustfmt.toml` file.
Can we
Sure. Setting the width to 100 will remove all merge conflicts, since rustfmt
won't touch anything. I set it to 80 to avoid line wrapping/scrolling.
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to cla-requests@gdlauncher.com and add your github handle to contributors list.
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to cla-requests@gdlauncher.com and add your github handle to contributors list.
I really think max_width
should be set to 80, otherwise there can be a lot of vertical scrolling or line wrapping, in this case for me, but also for users who work with more than one window open at a time.
Currently, the project does not have a rustfmt.toml, causing inconsistant formatting for users who contribute with a non-default global rustfmt.toml file.