gorilla-devs / GDLauncher-Carbon

GDLauncher Carbon is a simple, yet powerful Minecraft custom launcher with a strong focus on the user experience
https://gdlauncher.com
Other
127 stars 14 forks source link

Fabric 1.21.3 won't start #385

Open Makavel42 opened 5 days ago

Makavel42 commented 5 days ago

Newly created Fabric 1.21.3 profile with Fabric version 0.16.9 won't start, even without any mod.

On my end, it just goes back to the "play" icon after a few seconds, without an error message, but I have the following logs:

image

From the log file, since I couldn't copy from the gui (would copy the instance ID instead):

[2m2024-11-30T01:50:14.037220Z TRACE carbon_app::api::instance::log: received log entry, entry: LogEntry { source_kind: StdErr, logger: "GDLauncher", timestamp: 1732931412736, thread: "N/A", level: Info, message: "Exception in thread \"main\" java.lang.ExceptionInInitializerError\r\n\tat net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)\r\nCaused by: java.lang.IllegalStateException: duplicate ASM classes found on classpath: jar:file:/C:/Users/makav/AppData/Roaming/gdlauncher_carbon/data/libraries/org/ow2/asm/asm/9.7.1/asm-9.7.1.jar!/org/objectweb/asm/ClassReader.class, jar:file:/C:/Users/makav/AppData/Roaming/gdlauncher_carbon/data/libraries/org/ow2/asm/asm/9.3/asm-9.3.jar!/org/objectweb/asm/ClassReader.class\r\n\tat net.fabricmc.loader.impl.util.LoaderUtil.verifyClasspath(LoaderUtil.java:83)\r\n\tat net.fabricmc.loader.impl.launch.knot.Knot." } at crates\carbon_app\src\api\instance\mod.rs:1748

It seems to work with older versions of Fabric (like 0.16.1). Vanilla and Forge will also work just fine, same for Fabric with Minecraft 1.21.1. Fabric will also work fine using the Minecraft launcher.

While I'm not a programmer, I noticed that it seems to try to use both version 9.3 and 9.7.1 of the OW ASM classes. I tried to remove version 9.3, but it would reinstall it as soon as I try to launch my Fabric instance.

While looking for a solution, I ended up on a post on Reddit for another laumcher that seems to have a similar issue where the solution looked like removing the dependencies to version 9.3 would fix the issue.

Some posts mentionned to edit the file "fabric-loader-0.16.9-1.21.3.json" to remove/edit the artifact to remove/replace the ASM 9.3 entry for 9.7.1, but I couldn't find the file.

desaianand1 commented 4 days ago

This is a duplicate of #383. Please refer to that issue for further updates. This can be closed