Physics Hold + Kerbal Health incompatibility

[yalov]

way to reproduce:

• land a base on a surface with Jeb and Bob
• enable Physics Hold radiobutton
• check Jeb and Bob health change/day in Health Monitor (Kerbal Health). It will be, for example, -3.0, -2.0 respectively.
• EVA a Jeb, and check health change/day. It will be something like -13.0, -2.0
• send Jeb back inside the base
• expected health change/day back to -3.0, -2.0, but is still -13.0, -2.0.

@GarwelGarwel

[gotmachine]

KerbalHealth seems to be have different code paths based on if the vessel is packed or not, see here : https://github.com/GarwelGarwel/KerbalHealth/blob/25adc8c7089c7b33da7362f1bccaae2e88b2df24/Core.cs#L186-L195

Can't say why the issue you describe is happening exactely but in any case there is nothing that can be done from the Physics Hold side, as it put vessels in the packed state by design, which is a standard stock state.

I guess what happens is that KH only update stuff on loaded and unpacked vessels. If so, this is a debatable assumption but I guess there is some technical explanation behind that choice since this was explicitly introduced in this commit : https://github.com/GarwelGarwel/KerbalHealth/commit/24cbc1a14494c7db4fa24529c766deab497c7952