search

gptscript-ai / knowledge

Knowledge for GPTScript
https://gptscript-ai.github.io/knowledge/
Apache License 2.0
29 stars 14 forks source link

Fix: add proper status to finished state and unsupported files #130

Closed StrongMonkey closed 1 month ago

StrongMonkey commented 1 month ago

We need to add proper status to indicate finished state. Completed state is not enough because it could be completed state in earlier step while it is still running. Also for unsupported files we also emit log so that the file will have a status showing unsupported.

https://github.com/gptscript-ai/otto/issues/86 https://github.com/gptscript-ai/otto/issues/87

StrongMonkey commented 1 month ago

Can't we just do "if phase == store && status == completed" instead of introducing the "finished" status? (Not sure about the phase here)

@iwilltry42 it appears that in other places we also set phase == store && status == completed other than finished state. So that's why I want to introduce a state that mark the file as completed.

iwilltry42 commented 1 month ago

Can't we just do "if phase == store && status == completed" instead of introducing the "finished" status? (Not sure about the phase here)

@iwilltry42 it appears that in other places we also set phase == store && status == completed other than finished state. So that's why I want to introduce a state that mark the file as completed.

Yeah that's true, we set it for all the stages, so it only implies finished if it's set with no stage specified.

Let's roll with the finished state for now 👍