grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.62k stars 299 forks source link

Allow Round-Robin Notification Step to Set Importance #1184

Closed thomasmitchell closed 1 week ago

thomasmitchell commented 2 years ago

Currently, you can set the type of notification sent (default or important) for other step-types such as Notify Users from Schedule or Notify Users, but there is no such option for the Round Robin notification step.

Additionally, it is unclear what kind of notification will currently be sent if a round-robin notification is triggered.

So this is a feature request for Round-Robin step to allow setting the notification importance level.

https://grafana.zendesk.com/agent/tickets/157288

qmonitoring commented 1 year ago

Indeed, there is no mention in the documentation what kind of notification will be sent (Default or Important) if a round-robin escalation step is chosen.

ethanmdavidson commented 1 year ago

Just did a quick test and it sent the notification at "default" level, which appears to be, ahem, the default. (seems obvious in hindsight!)

To add a usecase here, I'd like to use round-robin as a backstop for the oncall schedule. for example, the escalation chain would be:

  1. notify the scheduled on-call engineer
  2. wait 15 minutes
  3. notify the members of the team 1 by 1, round robin.

The intention here is that if the scheduled on-call engineer doesn't respond for some reason, someone else from the team hopefully will. This usecase would also be helped by https://github.com/grafana/oncall/issues/794

joeyorlando commented 4 months ago

@Ferril is there anything blocking this issue?

Konstantinov-Innokentii commented 3 months ago

@iskhakov @mackgorski it seems your opinion is needed here

Ferril commented 3 months ago

Related discussions - https://raintank-corp.slack.com/archives/C06K1MQ07GS/p1729086490888139

joeyorlando commented 1 month ago

@Ferril what's the latest update on this issue?

mackgorski commented 3 weeks ago

What @ethanmdavidson mentioned is exactly what customer originally requested apart of marking these notifications as important as I explained several times already. I will make sure to update this issue description. This part was also originally discussed in customer ticket in https://github.com/grafana/support-escalations/issues/11449 I am sure we have this logged as FR as well to implement a proper Round-Robin like solution here. Le me find the FR for the second part of this use case.