search

grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.49k stars 288 forks source link

Rename or Description for Schedules Rotations #1460

Closed Mazizieh closed 1 year ago

Mazizieh commented 1 year ago

In Grafana Oncall, cloud and I beleive open source version as well, there is no way to rename or add a description for Schedules Rotations.

Added rotations are having default names like L-1-1 and those a names can't be changed or at least having a description, like a GMT rotation or anything else. Grafana

Konstantinov-Innokentii commented 1 year ago

Moved to "in progress", since web and terraform uses different name fields which will lead to confusion. Ideally we want to show name from terraform in web and most importantly do not have two sources of truth for actual shift title.

Konstantinov-Innokentii commented 1 year ago

Opened a PR with backend. Now shift has a "name" field. When it's null frontend can show some default name (Lx-y Rotation), but send new name value if user modifies it. It is done because there is no way of defining y in "Lx-y Rotation" on backend while migrating. However, I'm not sure how frontend calculates y. Or maybe we can include inly x in rotation title? Going to discuss it with @maskin25 when he will be back from PTO.