grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.46k stars 279 forks source link

Allow customized SMS message without surrounding "Grafana OnCall" text #197

Open suess-ecbm opened 2 years ago

suess-ecbm commented 2 years ago

Currently SMS are not customizable except for a string in the middle of the fixed message:

You are invited to check an incident #515 with title "This is a test title" in Grafana OnCall organization: "this is a test organization", alert channel: Grafana Alerting - Grafana Alerting, alerts registered: 1, https://thisisatestorganization.grafana.net/a/grafana-oncall-app/?page=incident&id=I3H1WHSAJ8HWF Your Grafana OnCall <3

The users on our end do not universally speak English, nor do they interface with Grafana OnCall directly.

Therefore we would like to be able to change the whole message content without surrounding fixed references to Grafana Oncall, links and the ascii heart.

The current sms renderer could be changed to leave out that additional fixed text.

Matvey-Kuk commented 2 years ago

Feel free to contribute the change!

My opinion is that we still should have some unified prefix for all SMS to avoid system misuse. Smth like "Grafana OnCall alert:"

yokhahn commented 1 year ago

so it looks like there was a PR with a solution in https://github.com/grafana/oncall/pull/537, but it looks like it was closed stale by @vadimkerr after input from @Matvey-Kuk so what is the status of this?

Matvey-Kuk commented 1 year ago

@yokhahn if you would like to move this PR forward, I could suggest re-opening it and running through a review.

yokhahn commented 1 year ago

I've left some questions on the PR, so that I can understand what would need to be changed... the comments over there sort of left me with a lack of understanding of what would actually be needed to be changed.

github-actions[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had activity in the last 120 days.

adamkobor commented 4 months ago

We would be also happy to see something like this, because the default SMS template is practically unusable, since it doesn't hold any useful information

luvpreetsingh commented 2 months ago

One more thing is that the extra text is adding up to our SMS costs.

If you go here - https://twiliodeved.github.io/message-segment-calculator/

And type in

Grafana OnCall: Alert group #33753

from stack: “self_hosted_stack”, integration: My-integration - Grafana, alerts registered: 1.

This is almost 2 segments per SMS.

We are sending approx 25k-30k SMS per month and even 2 segments per SMS adds upto a lot of cost.

I would like to remove this additional text and get rid of it.

strauss115 commented 1 month ago

As already mentioned this extra text adds unnecessary costs + makes the messages less readable. As https://github.com/grafana/oncall/pull/537 was closed, I created another PR. This fixes this behaviour and it would be great to have it like that also in Grafana Cloud.

njohnstone2 commented 4 weeks ago

Why are SMS templates treated differently to the other templates in the first place (e.g. slack, web, etc)?

Can we move the existing hardcoded boilerplate template into the SMS template in the Integration's Template Settings? This would keep the template the same by default but user's that are looking to reduce SMS costs can still modify the template to suit their needs.

Like other's have described above, my use case is also wanting to make SMS messages more compact with only information that is essential to the alert.