grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.49k stars 288 forks source link

Pre-release schedule v2 bug collection #2118

Closed Matvey-Kuk closed 1 year ago

Matvey-Kuk commented 1 year ago

✅ 1) Schedule list, "Oncall" -> "On-call now"

Screenshot 2023-06-07 at 12 19 44

✅ 2) New schedule, "Additional notification settings" -> "Notification settings"

Screenshot 2023-06-07 at 12 20 48

✅ 3) Top nav stick to the top of the schedule screen:

Screenshot 2023-06-07 at 12 25 33

✅ 4) Didn't we update texts here? I think we agreed on "Delete past shifts".

Screenshot 2023-06-07 at 12 26 53

✅ 5) "Add rotation to the schedule to see users" -> "Add rotation to see users"

Screenshot 2023-06-07 at 12 59 17
raphael-batte commented 1 year ago

❓ There are white visual artefacts in the modal image

raphael-batte commented 1 year ago

✅ Show warning when user tries to save rotation without users. Modal shouldn't closes.

raphael-batte commented 1 year ago

Sometimes dropdown with recurrence option is empty image

raphael-batte commented 1 year ago

Week start settings and days arrangement in the modal should be the same image

Ferril commented 1 year ago

Some weird prerendered shifts behavior when opening update shift window

Screenshot 2023-06-07 at 12 11 47

(pressed on the first shift and rotation broke)

Screenshot 2023-06-07 at 12 12 24

After pressing "update" shift was moved forward to 06.06 but the start date is 05.06

Screenshot 2023-06-07 at 12 17 50
Matvey-Kuk commented 1 year ago

Use-cases for repeters:

Grafana-style rotation 8-8-8: Recurrence period: 1 week Mask by weekdays: Mo, Tu, We, Th, Fr Limit each shift length: 8h People: Group 1: [Alex] Group 2: [Bob]

Expected outcome: Week 1: Mo | Tu | We | Th | Fr | St | Su | [Alex, 8h] | [Alex, 8h] | [Alex, 8h] | [Alex, 8h] | [Alex, 8h] Week 2: Mo | Tu | We | Th | Fr | St | Su | [Bob, 8h] | [Bob, 8h] | [Bob, 8h] | [Bob, 8h] | [Bob, 8h]

Customer's daily rotation 8h: Recurrence period: 1 day Mask by weekdays: Mo, Tu, We, Th, Fr Limit each shift length: 8h People: Group 1: [Alex] Group 2: [Bob]

Expected outcome: Week 1: Mo | Tu | We | Th | Fr | St | Su | [Alex, 8h] | [Bob, 8h] | [Alex, 8h] | [Bob, 8h] | [Alex, 8h] Week 2: Mo | Tu | We | Th | Fr | St | Su | [Bob, 8h] | [Alex, 8h] | [Bob, 8h] | [Alex, 8h] | [Bob, 8h]

Ferril commented 1 year ago

Grafana-style rotation doesn't work correctly. test timezone - timezone GTM+2 In this example rotation starts on Monday, user - Matias. On Tuesday user changes to Maxim. Next week starts with Maxim and changes to Matias.

Screenshot 2023-06-07 at 12 44 07 Screenshot 2023-06-07 at 12 44 15

On open shift edit window, chosen weekdays are different

Screenshot 2023-06-07 at 13 00 46

It doesn't affect real shifts. But if you rename the rotation, weekdays of shifts will change

Screenshot 2023-06-07 at 13 03 27
Matvey-Kuk commented 1 year ago

Also reproducing: https://github.com/grafana/oncall/issues/2048

raphael-batte commented 1 year ago

Hide working hours in user's blocks in case recurrence period more than 1 week image

Matvey-Kuk commented 1 year ago

Also not fixed: https://github.com/grafana/oncall/issues/1820

Matvey-Kuk commented 1 year ago

This release will close: https://github.com/grafana/oncall/issues/1508

Matvey-Kuk commented 1 year ago

This release will close: https://github.com/grafana/oncall/issues/2118

DUPLICATE

Matvey-Kuk commented 1 year ago

This release will close: https://github.com/grafana/oncall/issues/1505

Matvey-Kuk commented 1 year ago

✅ This release will close: https://github.com/grafana/oncall/issues/1462

Matvey-Kuk commented 1 year ago

✅ This release will close: https://github.com/grafana/oncall/issues/1460

Matvey-Kuk commented 1 year ago

✅ Also not fixed: https://github.com/grafana/oncall/issues/1433

Matvey-Kuk commented 1 year ago

Magic with Monday when my first day is Sunday:

https://github.com/grafana/oncall/assets/3284841/704311e6-b4d3-4fc2-a9e8-fe7edd6c8e53

Matvey-Kuk commented 1 year ago

Boolean filters doesn't stay in the same state after getting back from the schedule:

https://github.com/grafana/oncall/assets/3284841/143e9c1d-ba7c-4ff2-9553-4d4a3cae9302

raphael-batte commented 1 year ago

Still have visual artefacts in rotation creation modal (Chrome Version 114.0.5735.90 (Official Build) (arm64)) image

Looks like they are connected to overflow: scroll parameter image

raphael-batte commented 1 year ago

❌ z-index battle, won't fix atm

When user creates override from shift, tooltip should be below the modal. image

raphael-batte commented 1 year ago

✅ Rotation renaming doesn't work.

raphael-batte commented 1 year ago

❓ When we move courser over rotation title, modal header twitches.

https://github.com/grafana/oncall/assets/102970268/986abc4b-efb6-47dc-a7e6-ec733a4a3b36

raphael-batte commented 1 year ago

Rotation creation modal polishing.

image

raphael-batte commented 1 year ago

Labels are broken.

  1. Escalations and warning labels inside should have an icons
  2. Escalations label should be green image image
matiasb commented 1 year ago

:white_check_mark: This release will close https://github.com/grafana/oncall/issues/1322

matiasb commented 1 year ago

I guess we can close this one? Let's open new issues for new bugs.