Closed Matvey-Kuk closed 1 year ago
❓ There are white visual artefacts in the modal
✅ Show warning when user tries to save rotation without users. Modal shouldn't closes.
❓
Sometimes dropdown with recurrence option is empty
✅
Week start settings and days arrangement in the modal should be the same
✅
Some weird prerendered shifts behavior when opening update shift window
(pressed on the first shift and rotation broke)
After pressing "update" shift was moved forward to 06.06 but the start date is 05.06
✅
Use-cases for repeters:
Grafana-style rotation 8-8-8: Recurrence period: 1 week Mask by weekdays: Mo, Tu, We, Th, Fr Limit each shift length: 8h People: Group 1: [Alex] Group 2: [Bob]
Expected outcome: Week 1: Mo | Tu | We | Th | Fr | St | Su | [Alex, 8h] | [Alex, 8h] | [Alex, 8h] | [Alex, 8h] | [Alex, 8h] Week 2: Mo | Tu | We | Th | Fr | St | Su | [Bob, 8h] | [Bob, 8h] | [Bob, 8h] | [Bob, 8h] | [Bob, 8h]
✅
Customer's daily rotation 8h: Recurrence period: 1 day Mask by weekdays: Mo, Tu, We, Th, Fr Limit each shift length: 8h People: Group 1: [Alex] Group 2: [Bob]
Expected outcome: Week 1: Mo | Tu | We | Th | Fr | St | Su | [Alex, 8h] | [Bob, 8h] | [Alex, 8h] | [Bob, 8h] | [Alex, 8h] Week 2: Mo | Tu | We | Th | Fr | St | Su | [Bob, 8h] | [Alex, 8h] | [Bob, 8h] | [Alex, 8h] | [Bob, 8h]
✅
Grafana-style rotation doesn't work correctly. test timezone - timezone GTM+2 In this example rotation starts on Monday, user - Matias. On Tuesday user changes to Maxim. Next week starts with Maxim and changes to Matias.
On open shift edit window, chosen weekdays are different
It doesn't affect real shifts. But if you rename the rotation, weekdays of shifts will change
✅
Also reproducing: https://github.com/grafana/oncall/issues/2048
✅
Hide working hours in user's blocks in case recurrence period more than 1 week
✅
Also not fixed: https://github.com/grafana/oncall/issues/1820
✅
This release will close: https://github.com/grafana/oncall/issues/1508
This release will close: https://github.com/grafana/oncall/issues/2118
DUPLICATE
✅
This release will close: https://github.com/grafana/oncall/issues/1505
✅ This release will close: https://github.com/grafana/oncall/issues/1462
✅ This release will close: https://github.com/grafana/oncall/issues/1460
✅ Also not fixed: https://github.com/grafana/oncall/issues/1433
✅
Magic with Monday when my first day is Sunday:
https://github.com/grafana/oncall/assets/3284841/704311e6-b4d3-4fc2-a9e8-fe7edd6c8e53
✅
Boolean filters doesn't stay in the same state after getting back from the schedule:
https://github.com/grafana/oncall/assets/3284841/143e9c1d-ba7c-4ff2-9553-4d4a3cae9302
❓
Still have visual artefacts in rotation creation modal (Chrome Version 114.0.5735.90 (Official Build) (arm64))
Looks like they are connected to overflow: scroll parameter
❌ z-index battle, won't fix atm
When user creates override from shift, tooltip should be below the modal.
✅ Rotation renaming doesn't work.
❓ When we move courser over rotation title, modal header twitches.
https://github.com/grafana/oncall/assets/102970268/986abc4b-efb6-47dc-a7e6-ec733a4a3b36
✅
Rotation creation modal polishing.
✅
Labels are broken.
:white_check_mark: This release will close https://github.com/grafana/oncall/issues/1322
I guess we can close this one? Let's open new issues for new bugs.
✅ 1) Schedule list, "Oncall" -> "On-call now"
✅ 2) New schedule, "Additional notification settings" -> "Notification settings"
✅ 3) Top nav stick to the top of the schedule screen:
✅ 4) Didn't we update texts here? I think we agreed on "Delete past shifts".
✅ 5) "Add rotation to the schedule to see users" -> "Add rotation to see users"