grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.51k stars 290 forks source link

[Bug] Helm Chart renders Ingress resource with deprecated kubernetes.io/ingress.class annotation #2253

Open itspngu opened 1 year ago

itspngu commented 1 year ago

When using the Helm Chart to deploy OnCall OSS, creation of the Ingress resource fails with the following error:

Ingress.extensions "grafana-oncall" is invalid: annotations.kubernetes.io/ingress.class: Invalid value: "nginx": can not be set when the class field is also set

https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation

Depending on the cluster's Kubernetes version, only one of the annotation or spec.className should be set.

# values.yaml

ingress:
  enabled: true
  className: nginx-internal
  annotations:
    ingress.kubernetes.io/ssl-redirect: "true"
    kubernetes.io/tls-acme: "true"
  tls:
    - hosts:
        - "{{ .Values.base_url }}"
      secretName: grafana-oncall-ingress-tls

Versions:

itspngu commented 1 year ago

/kind bug

mike-serchenia commented 1 year ago

tmp workaround

            annotations:
              kubernetes.io/ingress.class: null 
mike-serchenia commented 1 year ago

the same kind of issue with cert-manager.io/issuer: letsencrypt-prod in ingress, if

cert-manager:
            enabled: false

then no cert-manager annotations must be added