Use external redis without password and with sentinel support

slax81 commented 1 year ago

What went wrong?

What happened:

OnCall helm chart can't work with an external Redis instance that has no authentication, also there are no options to set up sentinel configuration.
Also, passwordkey field for the external rabbitmq password is incorrect. Should be: the key in the secret containing the rabbitmq password passwordKey: rabbitmq-password

What did you expect to happen:

Ability to use "" blank password when external Redis instance doesn't have authentication configured, also more options to define sentinel hosts, port, and set name (mymaster)

How do we reproduce it?

Configure external Redis in helm chart, set the password as "" and deploy it externalRedis: host: password:
- use an existing secret for the redis password existingSecret: ""
- the key in the secret containing the redis password passwordKey:

Grafana OnCall Version

v1.2.44

Product Area

Helm

Grafana OnCall Platform?

Kubernetes

User's Browser?

No response

Anything else to add?

No response

njohnstone2 commented 1 year ago

@slax81 have you been able to workaround this issue?

slax81 commented 1 year ago

@njohnstone2 No, had to use redis from the chart

rknightion commented 1 year ago

@njohnstone2 @slax81 this worked for me (in values file) to get external redis working with elasticache (no sentinel):

env:
  - name: REDIS_USERNAME
    value: ""
  - name: REDIS_PASSWORD
    value: ""
  - name: REDIS_HOST
    value: "whatever.use1.cache.amazonaws.com"
  - name: REDIS_PORT
    value: "6379"
  - name: REDIS_PROTOCOL
    value: "redis"

daddyy commented 1 month ago

Hi, I would like to take a closer look at this issue regarding the Sentinel configuration, specifically adding options for hosts where the ports may vary. Before I start implementing any changes, I wanted to reach out to see if the authors have any specific thoughts or preferences on how they envision the implementation. Your insights would be greatly appreciated and will help ensure that the changes align with the project's direction. Thank you!

MedAzizTousli commented 4 weeks ago

I also would like to setup an ExternalRedis (Standalone though) that does not need a password.

grafana / oncall