search

grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.49k stars 288 forks source link

Schedules. Incorrect link (+link color) for schedule quality metric documentation #2357

Closed raphael-batte closed 1 year ago

raphael-batte commented 1 year ago

What went wrong?

If we open quality tooltip and expand methodology section, there is a link to documentation in the text. image

It opens such page which is 404 https://grafana.com/docs/oncall/latest/calendar-schedules/web-schedule/#schedule-quality-report.

Also link has incorrect color - it should be blue without underline.

How do we reproduce it?

Open a schedule and hover mouse over schedule quality label.

Grafana OnCall Version

r175-v1.3.1

Product Area

Schedules

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response

vadimkerr commented 1 year ago

After merging https://github.com/grafana/oncall/pull/2358 I still see that the link is underlined, but can't figure out why (underline is false by default for the Text component).

Screenshot 2023-06-27 at 14 45 11

@grafana/grafana-oncall-frontend could you please take a look at this?

teodosii commented 1 year ago

@vadimkerr added the change in #2372