grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.51k stars 291 forks source link

All pages should show nicer loading state #2364

Closed joeyorlando closed 1 year ago

joeyorlando commented 1 year ago

What went wrong?

What happened:

Screenshot 2023-06-27 at 14 56 02

What did you expect to happen:

How do we reproduce it?

See above description under "What went wrong?"

Grafana OnCall Version

v1.3.1

Product Area

Schedules

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response

teodosii commented 1 year ago

👍 I strongly believe that all screens should be revisited and changed so that we provide some loading feedback to the user whenever the UI is waiting for backend to response. It's very annoying to switch filters/pages and not see any feedback while waiting for table data to change

teodosii commented 1 year ago

The remaining page that didn't have a loading indicator was Schedules - this was fixed in this PR https://github.com/grafana/oncall/pull/3172

At the moment of writing this comment all these pages show the loading indicator while loading the initial data: