Show magical shift swaps

grafana / oncall

Developer-friendly incident response with brilliant Slack integration

GNU Affero General Public License v3.0

3.49k stars 288 forks source link

Show magical shift swaps #2844

Closed Matvey-Kuk closed 1 year ago

Matvey-Kuk commented 1 year ago

What would you like to see!

I create shift swap for the time period when I'm not on-call (Thursday and Friday):

When it's created it's invisible because there is nothing to swap:

If I put myself on-call, shift swap request becomes visible.

This behaviour is "Magical" which we would like to avoid. I propose to show shift swaps even if they don't have anything to swap.

Let's: 1) Call "overrides" panel a "Overrides and swaps" 2) Move "Create shift swap" to the "Overrides and swaps" panel. 3) Show full shift swaps at this panel.

Product Area

Schedules

Anything else to add?

No response

github-actions[bot] commented 1 year ago

The current version of Grafana OnCall, at the time this issue was opened, is v1.3.25. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you :smile:!

raphael-batte commented 1 year ago

We can try to visualise ranges inside Swaps and overrides block.

In case user have just a empty range (for PTO for example) it will be visualised this way
If any user will take it, it will be marked by swapper name
In case shifts will be added to the period, SSRs will be created automatically.

raphael-batte commented 1 year ago

Web/mobile UIs unified visualisation possible direction

joeyorlando commented 1 year ago

Few minor things in the web UI that I noticed and thought were worthwhile pointing out:

currently on the backend only the user who creates the SSR can delete it. The UI should not show the delete button (or should grey it out), if the user viewing the request is not the one who created it. (atm if you try and click it you get a permission related error popup, which is expected).
if you try to create a shift swap request for a shift that happened in the past you get an error popup because the backend validates that the request is for shift(s) in the future. We should grey out the create button for past shifts

raphael-batte commented 1 year ago

Collection from 21/08

[ ] highlight new swap request block in the calendar by yellow color
[ ] disable renaming for the modal
[ ] add swap requester name to the field in the modal
[ ] 'Take' button is disabled for requester
[ ] Add link button to open SSR in Slack

- [ ] Naming Titles

Shift swap request - requested state
Shift swap - Accepted by user state Users
Requested by
Swapped by Buttons
Create
Accept