Improve type-safety: change TS strict mode - Githubissues

grafana / oncall

Developer-friendly incident response with brilliant Slack integration

GNU Affero General Public License v3.0

3.36k stars 262 forks source link

Improve type-safety: change TS strict mode #3335

Open brojd opened 8 months ago

brojd commented 8 months ago

Problem

Currently we use strict: false in tsconfig which disables set of other TypeScript rules: alwaysStrict strictNullChecks strictBindCallApply strictFunctionTypes strictPropertyInitialization noImplicitAny noImplicitThis useUnknownInCatchVariables

From docs: The strict flag enables a wide range of type checking behavior that results in stronger guarantees of program correctness

We should aim to enable it and fix all related issues.

Acceptance criteria

strict is set to true in tsconfig
all type issues are fixed after enabling it

Outcome

better type-safety in code
being able to catch type errors during development before they reach prod (shift left)
better developer experience thanks to increased number of type declarations and improved intellisense

github-actions[bot] commented 8 months ago

The current version of Grafana OnCall, at the time this issue was opened, is v1.3.57. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you :smile:!