UI bug related to time inputs for "current UTC time is in" range escalation policy step

grafana / oncall

Developer-friendly incident response with brilliant Slack integration

GNU Affero General Public License v3.0

3.44k stars 276 forks source link

UI bug related to time inputs for "current UTC time is in" range escalation policy step #3585

Closed joeyorlando closed 6 months ago

joeyorlando commented 9 months ago

What went wrong?

What happened: https://www.loom.com/share/15cb3e79af1f4c3cb2c5163d9440e074

What did you expect to happen:

when I type a valid value into the time range it should not show a red border
when I backspace the entire value I should not get a full page error

How do we reproduce it?

See demo video here

Grafana OnCall Version

v1.3.80

Product Area

Other

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response

maskin25 commented 8 months ago

@joeyorlando it displays a red border because the value must be a multiple of 5 (see minuteStep param), should we disable this restriction, WDYT?

joeyorlando commented 8 months ago

@maskin25 ohhh interesting. wonder if it's worthwhile adding a small note about that? (or at least giving validation feedback as to why the input is red/invalid).

maskin25 commented 8 months ago

@joeyorlando FYI after discussion with @raphael-batte we decided to get rid of this restriction, will do this in the next iteration

joeyorlando commented 6 months ago

closing as completed in #3659