grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.53k stars 293 forks source link

When OnCall Metrics are enabled they are exposed on path /metrics/ and not on /metrics #3597

Open ahladh opened 11 months ago

ahladh commented 11 months ago

What went wrong?

What happened:

When the Oncall plugin metrics are enabled using the variable FEATURE_PROMETHEUS_EXPORTER_ENABLED the metrics can be scraped from prometheus using the path http://<oncall-serviceip/dns>:8080/metrics/ and not using the path http://<oncall-serviceip/dns>:8080/metrics

Generally when we scrape metrics using Prometheus the default path to scrape metrics is done using /metrics path across the eco system.

image

What did you expect to happen:

When we scrape metrics from prometheus using /metrics/ path as per docs we are able to get the metrics. But I feel the slash at the end should not a compulsion which is even making user confusing while configuring.

Hope this is considered as in this ecosystem /metrics path should get the metrics without much efforts in customising the path.

How do we reproduce it?

  1. While Installting the Oncall Enable the /metrics/ path using FEATURE_PROMETHEUS_EXPORTER_ENABLED.

Grafana OnCall Version

v1.3.80

Product Area

Alert Flow & Configuration, Helm

Grafana OnCall Platform?

Kubernetes

User's Browser?

No response

Anything else to add?

No response

immuslim commented 9 months ago

im using chart version 1.3.106 with this values.yaml

 oncall:
    exporter:
      enabled: true

and create service monitor to scrape path /metrics/ port 8080 its works

paltaa commented 6 months ago

just confirmed that in chart version 1.4.4 with helm chart values:

 oncall:
    exporter:
      enabled: true

metrics are exposed but only works with /metrics/and not /metrics on port 8080.