grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.25k stars 253 forks source link

Clicking alert notification shows error inside mobile app if the wrong stack was selected #4286

Closed N3X14 closed 2 weeks ago

N3X14 commented 2 weeks ago

What went wrong?

What happened:

What did you expect to happen:

How do we reproduce it?

  1. Have at least 2 stacks in OnCall (App) [Cloud + on-prem in our case]
  2. Select one of them
  3. Fire an alert on the other while your screen is locked/you're outside the app
  4. Tap the notification that takes you to the app
  5. Error appears.

Grafana OnCall Version

1.4.3

Product Area

Mobile App

Grafana OnCall Platform?

Other

User's Browser?

Android App version 1.16.0 (latest)

Anything else to add?

Unfortunately I have no screenshot right now. If an alert fires, I'll make sure to take one or post the exact wording of the error message here.

We're not certain if this is also broken for iOS.

imtoori commented 2 weeks ago

I'm looking into this right now, I'll keep you posted

N3X14 commented 2 weeks ago

Thank you, appreciate it. (Un-)fortunately no alerts yet to provide a screenshot.

imtoori commented 2 weeks ago

Don't worry we managed to reproduce it and we have a fix ready. You'll find it in the next release (1.18.1). We're gonna push it out to the beta release (here you have the links if you want to give it a try iOS/Android) today and it will be promoted to stable on Monday. Thanks a lot for reporting the issue!

N3X14 commented 1 week ago

@imtoori

Just had the case with Android app v1.19.0. Presumably it should have been fixed in that version?

Clicking a notification that f.e. belongs to the "on-prem" stack while having the cloud stack selected results in "Connection error" "Not found." and a "try again" button that does nothing. image

Best

imtoori commented 1 week ago

hey @N3X14 we found another bug related to having multiple stacks, the latest version should work fine, it's in review by the play store and should be out shortly

N3X14 commented 1 week ago

Ah awesome - appreciate the information. Thank you for the prompt response!

Awesome work with OnCall!