search

grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.41k stars 272 forks source link

Refactor `apps.alerts.tasks.notify_user.notify_user_task` #4629

Open joeyorlando opened 1 month ago

joeyorlando commented 1 month ago

What would you like to see!

Related to a bug that was noticed by @Ferril (and patched in https://github.com/grafana/oncall/pull/4628)

This task is starting to become very complex. There are way too many conditional statements and possible code-flows. We should refactor this function into a much more readable/testable function.

Product Area

Other

Anything else to add?

No response

github-actions[bot] commented 1 month ago

The current version of Grafana OnCall, at the time this issue was opened, is v1.8.0. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you :smile:!

joeyorlando commented 1 month ago

TODO