search

grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.51k stars 291 forks source link

Support for GovSlack #4711

Open mkochco opened 4 months ago

mkochco commented 4 months ago

What would you like to see!

It looks like the Slack integration is hard-coded to use slack.com when integrating with the slack application. I'd like to see a feature to allow the slack integration to be setup using slack-gov.com (i.e. an option to select GovSlack).

Product Area

Chatops

Anything else to add?

Some of our incidents may contain information that is ITAR export controlled. Without the ability to push Alerts/Notifications to GovSlack we'll have to apply Routes that filter that information and monitor all notifications for any violations.

If there are other workarounds please advise.

github-actions[bot] commented 4 months ago

The current version of Grafana OnCall, at the time this issue was opened, is v1.8.5. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you :smile:!

mkochco commented 4 days ago

I was looking into potentially adding support for GovSlack. I have setup the development environment and fronted my localhost:3000 with localtunnel. I have been attempting to test the slack integration flow using both slack-gov.com and slack.com. However, it appears that after Slack authorizes and redirects back to grafana-oncall, the application doesn’t behave properly. Specifically I see a 404

{
  "message": "Not found"
}

As a response to the callback https://oncall5982.loca.lt/api/internal/v1/complete/slack-install-free/?slack_login_token=......omitted............&code=1329765234241.7440349654631.3c865ce2566e9f45d3e388f3176f22302bbc95b7ac0b668cf111cd5aeefb76dc&state= Again, I see the same behavior when testing against both slack-gov.com and slack.com. Is there something I’m missing on the devenv setup? (edited)