search

grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.43k stars 276 forks source link

Allow manually triggering a webhook #4748

Closed matiasb closed 1 day ago

matiasb commented 1 month ago

What would you like to see!

It should be possible to trigger a webhook in an alert group context via a custom action button.

Product Area

Alert Flow & Configuration

Anything else to add?

No response

github-actions[bot] commented 1 month ago

The current version of Grafana OnCall, at the time this issue was opened, is v1.8.8. If your issue pertains to an older version of Grafana OnCall, please be sure to list it in the PR description. Thank you :smile:!

natellium commented 1 month ago

@matiasb @raphael-batte do we need some design work here?

raphael-batte commented 1 month ago

@natellium yes, definitely!

natellium commented 2 weeks ago

@matiasb @raphael-batte can you move this issue and its parent https://github.com/grafana/oncall-private/issues/2882 to In Progress if you get started? :)

raphael-batte commented 2 weeks ago

UX proposal based on WG call results with @matiasb and @teodosii

  1. We can use existing webhooks that have an Escalation step trigger as a Manual trigger, too. We need to rename the initial trigger type to have a broader naming to cover both cases. Image

  2. We add a new Item to the Actions button inside the AG page.

Current view: Image

Drafted suggestion (needs better icon)

Image

  1. By click we open modal and allow to select webhook from the list. The list shows only webhooks with relevant trigger type.

Image

  1. The event saved in the AG timeline

Figma link to @teodosii https://www.figma.com/design/sJ4RvHvnUq6AZAiHYYiB5j/Grafana-OnCall?node-id=12672-807&t=zj6wvP7FKf7dHREZ-1

matiasb commented 1 day ago

This is now deployed and available in prod.