grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.48k stars 285 forks source link

helm: allow specific pod annotations for migration job #5170

Open rowieg opened 1 week ago

rowieg commented 1 week ago

What this PR does

This pr adds the possibility to add specific annotations to the migration job pod

Motivation

Because Kubernetes jobs and services mesh applications are not that compatible in regards to finishing jobs and removing service mesh sidecar proxy containers these jobs stay forever.

With this change these pods can be explicitly marked via the annotation to skip the service mesh injection

For example:

If you are running a linkerd service mesh all pods within a namespace are automatically injected via an annotation to the namespace. This leads to Kubernetes jobs to never finish because the proxy is never finished. To disable this behaviour you can add the "linkerd.io/inject: disabled" annotation to the pod. This skips the injection process for this pod and the job then is finished.

Checklist

CLAassistant commented 1 week ago

CLA assistant check
All committers have signed the CLA.