Web-based calendar polishing collection for v1

[Matvey-Kuk]

Logical blocks: https://github.com/grafana/oncall/issues/531

[Matvey-Kuk]

@raphael-batte 's comments from #525:

• [ ] 1. Make rotation start <-> shift start linked by default.
• [ ] If we change rotation start date, shifts start time changes automatically. In user wants to customize shift start time, he should corrects it in this field manually.
• [x] 2. Mark fields with errors by red color focus (with error messages)
• [x] 3. Add days of the week to the timeline –> Mon 12 Sep
• [ ] 4. Add warnings about gaps in finale schedule: warning overlay + instant warning label near headline (without page refreshing) moved to https://github.com/grafana/oncall/issues/666
• [x] 5. Optimize overlay block to small screens
• [x] 6. Disable overlay hiding by click outside
• [x] 7. Separate date/time picker to 2 components -> date+time
• [x] 8. Allow to edit rotations by clicking from final schedule
• [ ] 9. Visual decoration for weekends as second step POSTPONED

[raphael-batte]

• [x] Wrong local time right top corner
• [x] Lag on click existing rotation before popup appear
• [x] Sector over users
• [x] User tooltip should appear under avatar
• [x] Remove back button hover circle and alight it to main vertical axe.
• [x] Blocks color -bg-secondary, hover -overlay
• [ ] Merge final schedule to as less rows as possible POSTPONED
• [ ] Export to google calendar POSTPONED
• [ ] Add working hours to user settings moved to https://github.com/grafana/oncall-private/issues/1434
• [x] Mark users with broken working hours as 'outside working hours users' by linear bg without error message
• [x] Hide unactive icons

[raphael-batte]

• [x] Lock 'Save' button if user doesnt have users in schedule

[vadimkerr]

• [x] Add ability to specify by_day for events of every frequency (hourly, daily, weekly, etc.)
• [x] (Backend) Fix bug with 0 length shift if rotation end is set
• [x] (Frontend) Remove ability to click “Create” if no users are added
• [x] (Backend?/Frotntend?) Make rotation start depend on shift end (disable rotation start input by default)

[mderynck]

• [x] Need a way to access the settings below for the new schedules.

[raphael-batte]

• [x] Implement schedule's additional settings design to frontend
• [x] allow page layer scrolling when overlay is opened
• [x] allow closing all popup-overlays by Esc key
• [x] add overflow=hidden to user's timezones widget

[raphael-batte]

Schedules list:

• [ ] hide connections icon when schedule unused in escalations (moved to https://github.com/grafana/oncall/issues/666)
• [x] add schedule type column (web/ical/api)
• [x] add slack channel column
• [x] expand row by click on angle icon as well
• [x] bg-color for expanded part of the row should be equal to parent row bg-color

Schedule detailed page:

• [x] Rename in rotation overlay Shift start/Shift end => Parent shift start/Parent shift end
• [ ] fix random shifts animated movements when we create or change rotation POSTPONED
• [x] link Parent shift start – Parent shift end segment length when we change Parent shift start time. Endpoint at this case should move automatically. This behaviour is only for Parent shift start point. When user moves Parent shift end - shift length is change.
• [x] Add shift Parent shift start – Parent shift end animated visual connection between rotation overlay and main layer FIGMA 1 FIGMA 2
• [ ] Add panel styled controllers to Layers : dropdown menu with rename and delete POSTPONED
• [x] Add Bold text decoration to current date in calendar grid
• [x] Remove 16 px bottom margin under h4 in user timezones block
• [ ] Fix tooltip design for user shifts FIGMA POSTPONED

[Matvey-Kuk]

Hey team, I decided to do a pretty diligent "final check". There is a chance that some of points mentioned here are not actual bugs. Please ignore them in this case:

Tested in ops.grafana.net, r36-v1.0.50, chrome:

• [ ] 0. Let's rename "Schedules α" to "Schedules NEW" because we're going to roll it to Grafana Cloud. It's not an Alpha anymore :)
• [x] 1. User could go to "Schedules α" and try creating ICal schedule. Since we don't show Ical schedules in this page, user will see an empty list after creating one. We either should render new+old schedules on "Schedules α" page, either don't allow to create Ical schedules on the "Schedules α" page. Just disable this button.
• [x] 2. While creating a schedule we have an option "Create schedule by API" with sub-text "Configure rotations and upload calendar by Terraform file". It's not correct, we don't allow "uploading" terraform, we allow "applying Terraform to our API". Also the link is misleading because API-based schedule could be created only using API, not through UI. I propose such a sub-text: "Use API or Terraform to manage rotations". Instead of "Create" I propose "Read more" leading to https://grafana.com/blog/2022/08/29/get-started-with-grafana-oncall-and-terraform/ in a new tab.
• [x] 3. Bug:
  • I create rotation.
  • I delete rotation which "cuts it" (as expected)
  • I click the leftover piece of the rotation. It gives me 500.
  • I'm not able to change anything anymore.

https://user-images.githubusercontent.com/3284841/199861595-8e8cdfa7-5097-4ef3-b12e-cb8d841fc192.mov

I think it's a frontend & backend bug. Frontend shouldn't lock after 500's. Backend obviously shouldn't give us 500's :)

• [ ] 4. Override edit renders with a small excessive piece. It's probably related to the fact that I recently changed timezone from Jerusalem to New York. That's a non-blocking bug. I'm ok to roll with it being non-fixed:

https://user-images.githubusercontent.com/3284841/199862402-6afbd3df-918b-48ea-8ea0-7fe6ff0cde32.mov

• [x] 5. Cannot delete override which is happening now:

https://user-images.githubusercontent.com/3284841/199862733-8a5cb83b-fb80-4fe5-9583-293dd9b5f8eb.mov

[Matvey-Kuk]

I didn't realize we already show all schedules in "Schedules alpha" page. So #0 and #1 are not relevant. Let's just remove old schedules page.

[mderynck]

• [ ] Exported ical link has incorrect level for override (In the UI I am overriding but in the export I have L0)

[vadimkerr]

5. Cannot delete override which is happening now:

@maskin25 I checked the backend part, the override deletion works the same as deletion of regular shifts. When making a DELETE request, backend returns 204 and sets the until property to current time. This seems to be working fine for regular (non-override) shifts, so could you please check if there's some issue on the frontend part for overrides?

[matiasb]

5. Cannot delete override which is happening now:

@maskin25 I checked the backend part, the override deletion works the same as deletion of regular shifts. When making a DELETE request, backend returns 204 and sets the until property to current time. This seems to be working fine for regular (non-override) shifts, so could you please check if there's some issue on the frontend part for overrides?

FYI, I was also checking, indeed the until is being set, but there is some change required in the backend to enforce the until in overrides shifts (no changes should be required in the frontend as far as I can tell), I have a PR in progress with the update (and some other schedule-related fixes I'm working on)

[maskin25]

5. Cannot delete override which is happening now:

@maskin25 I checked the backend part, the override deletion works the same as deletion of regular shifts. When making a DELETE request, backend returns 204 and sets the until property to current time. This seems to be working fine for regular (non-override) shifts, so could you please check if there's some issue on the frontend part for overrides?

FYI, I was also checking, indeed the until is being set, but there is some change required in the backend to enforce the until in overrides shifts (no changes should be required in the frontend as far as I can tell), I have a PR in progress with the update (and some other schedule-related fixes I'm working on)

good, let me know when you're done

[raphael-batte]

• [ ] Prop 1. Add more clear message UI to iCal and API calendars. + Management buttons should be hide

  

• [ ] Prop 2. Remove message from the top and add tooltips for disabled buttons.

• [ ] Add overrides feature to iCal/API schedules

[raphael-batte]

• [ ] List view. If user expands row, calendar widget isn't adopted per page width (it more than 1400 px wide).

[raphael-batte]

• [ ] Long names fix for overlays. Two proposals - 1)gradient + padding 2)clear cut + padding

[raphael-batte]

User presentation visual issues

• [ ] shift color border should be positioned to the center or outside parent shape (now it is inside and we can see artifacts)

• [ ] users outside working hours should be disabled visually. Example - Singapore users already outside their working hours but look similar to others.

• [ ] some users have 2rows name-presentation

[Matvey-Kuk]

Closing this due to agreement not to make it a permanently open issue. @raphael-batte please file separate issues 🙏