Open greatvovan opened 1 year ago
After listening again, it might have been "Alert via ..., web hook with title ... triggered one time" (correction in bold). With that, it makes sense to put integration name here, but it means that the message must be corrected anyway, because both placeholders are prepared for the name of integration. An example of corrected message:
"Alert via integration name
titled alert group title
"
I also not sure what is the purpose of adding "triggered one time", and what are the situations when it can be more than "one".
@greatvovan you can check phone_call template here.
Based on the linked template, I am realizing I was wrong with the assumption that it is the template that is bad (maybe it is bad, too, but it is not the root cause). Let's check it carefully again:
The integration name:
The alert group name:
The voice message: https://soundcloud.com/fun-with-no-end/grafana-oncall-sample-notification-2 Transcript: "You are invited to check an incident from Grafana OnCall. Alert via My beautiful integration, web hook with title My wonderful alert group triggered one time. Press 1 to acknowledge, 2 to resolve, 3 to silence for 30 minutes".
Question: how does "web hook" part makes its way into the message?
@greatvovan {integration_name} in template consists from integration name and integration type
@Konstantinov-Innokentii that explains something. But how exactly? Do any commas or dots separate name and type?
Thinking more about the potential to improve the message, why do we not provide the user ability to form entire message, as in other destinations?
Currently the user can influence only Title and (in another place) name of integration.
Can we rename the field into Message and allow the user to form entire voice message as they wish?
Preparation
#2
to the integration through the default route.{{ payload.title }}
.{{ payload.title }}
.Repro steps
#3
.curl <URL_from_prep_step_3> -H 'Content-Type: Application/json' -d '{"title": "My wonderful alert group"}'
Expected behaviour
The message correctly identifies parameters of the alert group.
Actual behaviour
The voice message: "You are invited to check an incident from Grafana OnCall. Alert [illegible - fire?] My beautiful integration, web hook with title My wonderful alert group triggered one time. Press 1 to acknowledge, 2 to resolve, 3 to silence for 30 minutes". Titles of the alert group and integration are confused.
Environment
Grafana Cloud