search

grafana / oncall

Developer-friendly incident response with brilliant Slack integration
GNU Affero General Public License v3.0
3.5k stars 288 forks source link

Support discrete OnCall app plugins per Grafana Org, within Grafana OSS #962

Open devinrcheevers opened 1 year ago

devinrcheevers commented 1 year ago

Grafana OSS provides ability to create 'organizations'.

An organization is an entity that helps you isolate users and resources such as dashboards, annotations, and data sources from each other

A single grafana 'instance' can have multiple orgs.

My understanding is that the OnCall app plugin is associated with the instance of Grafana, not the specific org. In other words, I believe you can only have one OnCall app plugin per Grafana Instance.

This may be a limitation of the app plugin archicture, but would it be possible to provide the ability to have a per org oncall plugins?

devinrcheevers commented 1 year ago

This is related to: https://github.com/grafana/oncall/issues/764

Matvey-Kuk commented 1 year ago

The ability to have one Grafana OnCall instance per multiple Grafana instances is something I don't expect being reasonable to support for OnCall OSS. Mostly because it will increase variety of environments we support. Even though that's exactly how we launch OnCall in Grafana Cloud, we provide a few features which should help OSS uses deal with multiple teams and grafanas within the company: 1) There is a Team toggler 2) It's possible to set up Grafana OnCall in one Grafana & connect a few other Grafanas to it as alert sources.

PhantomPhreak commented 1 year ago

There are a few problems:

  1. In case if have multiple Oncall backends used by a single Grafana instance (one per Grafana Org, because Oncall backend is attached via Oncall plugin, and plugin's configuration is independent in different grafana Orgs), we have a problem mentioned in #764 .

But since Oncall is not allowing to add Org Viewers into rotation and sending alerts to them (see https://github.com/grafana/oncall/issues/524#issuecomment-1248278808 and https://grafana.com/docs/oncall/latest/configure-user-settings/#configure-user-notification-policies), there are no other way to configure rotations/alerts for the users without giving them Admin/Editor rights in the Org. Giving Admin/Editor rights in whole Org just for the ability to recieve alerts is way too much. That's related to OSS Grafana

  1. In case if one OSS Grafana instance is allowed to have a single Oncall Instance attached, then it's not gonna be possible to configure Oncall for the multiple teams, without giving them Editor/Admin rights to the Org.

From my perspective, it would be better to have a single Oncall backend for OSS Grafana instance (less entities to manage), but have a way to configure access permissions per Team (not per user role in the Org) for Oncall.

If it's not possible with a current architecture, then it would be nice to render a proper links to Oncall in Grafana, installed in the different Orgs